Skip to content

Added some missing repo files #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2019
Merged

Added some missing repo files #4

merged 2 commits into from
Feb 12, 2019

Conversation

makermelissa
Copy link
Collaborator

Added a setup.py file as well as adding some PyPI stuff to the Travis.yml file.

kattni
kattni suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! There's a step to the PyPI process that you can't do - I've explained below. As well there's a couple of other tweaks. If I missed anything, we'll find it when we try to deploy, which happens fairly often. :)

.travis.yml Outdated
- provider: pypi
user: adafruit-travis
password:
secure: DC9aEeXOKnkvA9tPIi/ePQIW0SHdxcvjrUuZpoC1BXtFPqpMh3l3/rblYPgvVsfP612g/4BjeMpVKJoAhTfChotmoLZfH7zXsRf4sWKYkvMfrLBth5fZSHqaELU9IBIXLs2740DBSM7h6HgN8lh0jiOmr2F/JUXilqMCmXMrozU/LskficUpC8exvnVX0+yM3Da5+Awp09mJixXrJkvxvB5VW01o4ewPxucXCSPpeVCCUpk1HYK1Qla9ZyOL+hwuZk5dzm1u4atw3IpbUQeEw4m8dpt+JAB+2439V9ekK5neUGben+a3a2WAmyvwo4sfF/EqtgF3048EWz4SqF60DE8G8BeMPGSs2gzfvULLXcyAwwgluSkfWk6pk0ULJc+mOE63vFODsONDIQs/zfIDu3fiI6TYMiYRh7u7NHIYpVHukGeC9q2sPTr/EeLxLOE0W+Npnf/+6wycmV4bjauhuS71EGkGIzV2/gE+iuqmoC8ileidCVnS+2UZj+tPR2yQEdUoyTvKa3KcRQsOpXGNvzqJtI1NnHPv5V8BfZXUrqBJrq55SCrGDdl6jZ3INSor+1ASs4Cv3iCsfF3P0a7dSOsBjDzH2SDLiupi1+XLHR7v8MmGsF6o1CIc6/ML2kqD6r7wgIlF3OSXrA2JVs2piw/zMu9r6MyTYXenzVw5cyg=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secure hash must be generated on a repo-specific basis using both specific GitHub and PyPI credentials. It's not a common hash. The new cookiecutter adds the rest of the info you added, but does not include the hash as that is the final step to deploying to PyPI.

setup.py Outdated
],

# What does your project relate to?
keywords='adafruit ra8875 driver hardware micropython circuitpython',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include more keywords. You put so much work into this - there's a lot more to it than simply its name! Include at least display, and anything else you find relevant. This is the set of keywords that is used when people are searching for a driver on PyPI.

setup.py Outdated

# You can just specify the packages manually here if your project is
# simple. Or you can use find_packages().
py_modules=['adafruit_ra8875'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py_modules must be changed to packages because this driver uses a package. The rest of the line will stay the same.

@kattni
Copy link
Contributor

kattni commented Feb 12, 2019

@makermelissa Ping me when you are working on this and I can generate the correct hash for you, then we can get PyPI deployed through this pull request.

@makermelissa
Copy link
Collaborator Author

makermelissa commented Feb 12, 2019 •
edited
Loading

Hi @kattni, I'm ready for the hash.

@kattni
Copy link
Contributor

kattni commented Feb 12, 2019

@makermelissa Excellent! Hopefully this works, I've never generated a hash without having cloned the repo first (it shouldn't be necessary the way we do it, but I've simply never tried).

AF+E8LEvOOLe66/++iw1plWdKmRH39gwdmzMzIJZlUdMGmbLYi0rFg+yC4+Xfvm9ZumG3aTLbWdzyvBHkB3H3/fT4YZf5mElxTEwGeYcOIburFQUNm0GqgXzKjfwvgH6lTNSWo2zibALrlytTnDPNvUfqyhAGvJBp2JgDUVS4kY1LjvzQSFCWcGNQ3F9kxsWeLHv34lTkjXQSrQNMLotjD4jVp6LAZMTbDtJKCGgfrYfOP60InVNWMuqVDB0DVFk+6ry8QbnTif9wsTiCoIAY7H25xFcJ/laFNRbx5nj3n+XVApM5EebJk+Ig5j/akSBa+MlmGvSTcHF+hP89+fRwhyJtu4qo2d1wu8D29lXs9VDVsw0tsix0CLFzEQsurUqaHfsZGSKnW9f/2v4+tyQyo4e3Hkvumm2Bu5xvREwnaAiSRw2Iavm9noGF/AnH5593AmKdkRtAWq0UrEDGKjp5enlZwhq1pkzM+7isOKDgsVOe2RnI1SXSgKq43qU2/xVCfhh5W/MBKLgLaTTH6iaXfSsZYwekuWIhdjE2IUf4rnbqjGhJIC/mObHAgsrrtWbKqDHuQg7xMV0MlSS5b1B6KuQrxouVz2BC/a9RcOm9k0EBHfqVEi1EJBfgJkYEeoCiKzwT+O2zhN5rgGC67NpVMKWfCl9sRT0gpZ9JE1H7OY=

kattni
kattni approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for doing this! Now let's see if we can get it deployed!

@kattni kattni merged commit ac0071a into adafruit:master Feb 12, 2019
@kattni
Copy link
Contributor

kattni commented Feb 12, 2019

@makermelissa Please do a release titled something like "Now on PyPI". Then we'll check Travis to make sure it deployed properly.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 23, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@56a4f43)
f7aed78 
Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#5 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#4 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#4 from adafruit/kattni-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_RA8875, Adafruit_CircuitPython_Bitmap_Font
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makermelissa @kattni