Skip to content

Prelim minimization work & fix bugs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

geudrik
Copy link

@geudrik geudrik commented Oct 9, 2021

Work in progress. This resolves the import depth issues reported here

Note that this PR is also likely necessary on some boards, as NTP can be a PITA (eg: on the Feather S2)

@geudrik
Copy link
Author

geudrik commented Oct 9, 2021

I've marked this as a WIP only because so far I've tested far enough to verify that the depth issues are resolved. I haven't actually tested functionality yet

@geudrik geudrik changed the title WIP: Prelim minimization work Prelim minimization work & fix bugs Oct 11, 2021
@brentru
Copy link
Member

brentru commented Oct 12, 2021

@geudrik Please tag me when you're ready for a review

@FoamyGuy
Copy link
Contributor

checking in with @geudrik, are you still working on this PR?

@geudrik
Copy link
Author

geudrik commented Jan 28, 2022

I unfortunately haven't touched this work in a few months (I moved). I got stuck buried in one of the other three MR's related to this though - this was a deep rabbit hole, and I don't know enough about how the MQTT protocol works to actually resolve it.

All of this work was together with adafruit/Adafruit_CircuitPython_GC_IOT_Core#20 and adafruit/Adafruit_CircuitPython_MiniMQTT#93 to get Pub/Sub plugged in and working on my S2 (see here for the final "here's where I got stuck")

@FoamyGuy
Copy link
Contributor

@geudrik it's all a bit over my head honestly. Don't have much experience with MQTT.

Do any of these PRs provide functionality or improvements that stand on their own? or are all really a package deal type of thing?

For now I think maybe we can close any that are stuck for the time being? If we do, definitely feel free to re-open or create new PRs if you do end up getting back into it and unblocked.

@geudrik
Copy link
Author

geudrik commented Jan 31, 2022

Feel free to close for now. Most should stand on their own, though I can't speak to their current state or how else they may interact with other adafruit libs. It was a compound issue - stack depth issues was the first piece of cleanup, then mqtt/pubsub since that doesn't work at all currently.

@brentru brentru closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants