Skip to content

Add StreamHandler to logger, add missing dependencies #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2022
Merged

Add StreamHandler to logger, add missing dependencies #34

merged 2 commits into from
Jun 7, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jun 7, 2022

Resolves #33 by adding a StreamHandler to the Logger, and pins the minimum version of adafruit_logging. Also adds missing dependencies.

@tekktrik tekktrik requested a review from a team June 7, 2022 02:27
tannewt
tannewt approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit e2a326d into adafruit:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

May need update due to adafruit_logging 4.0.0
2 participants
@tekktrik @tannewt