Only error if both imports cannot be found, otherwise use pwmio #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Jul 22, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 22, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.0.8 from 3.0.7: > Updated name Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.9 from 2.0.8: > Removed double license Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.8 from 1.1.7: > Replaced name Updating https://github.com/adafruit/Adafruit_CircuitPython_Ducky to 1.0.7 from 1.0.6: > Updated name Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.15 from 2.4.14: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#32 from tekktrik/fix/fix-pwmio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on using this with my QTPy ESP32-S2, I think the intent is to try and use
audioioandadafruit_waveformif possible, but default topwmioif needed (if not both, in other words, tell the user to addadafruit_waveformONLY ifaudioiois available). This fixes an issue with the logic currently preventing usage of this library on boards withoutaudioio. Tested withAdafruit CircuitPython 8.0.0-alpha.1 on 2022-06-09; Adafruit QT Py ESP32S2 with ESP32S2.Fixes #31