Skip to content

Add basic UART xfer #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Add basic UART xfer #2

merged 4 commits into from
Feb 28, 2020

Conversation

caternuson
Copy link
Contributor

Just the basic AT command xfer. Assume further parsing will be done in command specifics functions to be added later.

Adafruit CircuitPython 5.0.0-rc.0 on 2020-02-26; Adafruit ItsyBitsy nRF52840 Express with nRF52840
>>> import board
>>> from adafruit_rockblock import RockBlock
>>> rb = RockBlock(board.UART())
>>> rb._uart_xfer('+GMI')
'Iridium'
>>> rb._uart_xfer('+GMM')
'IRIDIUM 9600 Family SBD Transceiver'
>>> rb._uart_xfer('hello world')
'ERROR'
>>> rb._uart_xfer('+SBDSX')
'+SBDSX: 0, 1, 0, -1, 0, 0'
>>> 

@ladyada
Copy link
Member

ladyada commented Feb 28, 2020

wanna make this a draft PR while you add more?

@caternuson
Copy link
Contributor Author

Adafruit CircuitPython 5.0.0-rc.0 on 2020-02-26; Adafruit ItsyBitsy nRF52840 Express with nRF52840
>>> import board
>>> from adafruit_rockblock import RockBlock
>>> rb = RockBlock(board.UART())
>>> rb.model
'IRIDIUM 9600 Family SBD Transceiver'
>>> 

@caternuson
Copy link
Contributor Author

I think I'd have to re-submit to make it draft? Not seeing a way to change. Or could have a series of PRs that each add some functionality? This is like the very first baby step. More PRs to come later.

And maybe we should create issues as we go also?

@ladyada
Copy link
Member

ladyada commented Feb 28, 2020

well its passin' so im ok mergin for now

@ladyada ladyada merged commit c95a2da into adafruit:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants