Skip to content

Renaming driver/class to match product/repo name. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Aug 7, 2018

This renames the driver and the class to match the product description and the repo name. References to the original name have been updated.

This will require the guide be updated. Once this is merged I will attend to that.

@kattni kattni requested review from brennen and caternuson August 7, 2018 19:45
@caternuson
Copy link
Contributor

Looks good. For future ref, here's the background on this. Sensor part number decoder ring:

SHT3x-yyy-c

x: 0=low-cost, 1=standard, 5=high-end
yyy: ARP=analog, DIS=digital
c: B=bare, F=filter membrane, P=protective cover

PID2857 uses a SHT31-DIS-F. Product page calls it a "SHT31-D". Decided to have the module and class name match this better.

@caternuson caternuson merged commit d691567 into adafruit:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants