Skip to content

Start linting #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Start linting #1

merged 3 commits into from
Feb 27, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 30, 2023

No description provided.

@tannewt tannewt marked this pull request as ready for review January 30, 2023 21:45
@tannewt tannewt requested a review from a team January 30, 2023 21:48
Comment on lines 49 to 50
.. note:: This library is not available on PyPI yet. Install documentation is included
as a standard element. Stay tuned for PyPI availability!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we are doing everything on PyPi now, and that the cookie-cutter choices do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still here in the cookiecutter, likely under the assumption that maybe community libraries won't publish (or at least that was my thought). It may be worth removing this from the template, or at least doing so if it's an Adafruit library.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't put it on pypi because blinka displayio hasn't been updated to work with acep displays. I imagine it will be at some point though. That's why I left it here.

@jepler
Copy link

jepler commented Jan 31, 2023

Because the workflow for installing on esp32 with thonny always goes via pypi, not via circup/bundle, we decided that all packages would be published on pypi, even if they do not work with blinka yet.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting looks good to me.

Merging this one.

Follow up PR incoming with the pypi note removed as well as one other tweak needed for the driver to work

@FoamyGuy FoamyGuy merged commit 60ff3c8 into adafruit:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants