Skip to content

Demonstrate black formatting with pylint, GHA #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2020
Merged

Demonstrate black formatting with pylint, GHA #25

merged 5 commits into from
Mar 13, 2020

Conversation

amyreese
Copy link
Contributor

@amyreese
Copy link
Contributor Author

Needs adafruit/actions-ci-circuitpython-libs#5 to be accepted so that black is available for use in the build actions.

tannewt
tannewt approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Any other @adafruit/circuitpythonlibrarians have an objection?

@sommersoft
Copy link
Collaborator

I don't have any non-opinionated objections that would necessarily override standard formatting.

@sommersoft
Copy link
Collaborator

That wasn't meant to sound that negative. I'm in full support of formatting, and I don't see any issues with how the action step is setup. 😄

@kattni kattni merged commit cffe8df into adafruit:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyreese @sommersoft @tannewt @kattni