Skip to content

fixing docs badge, adding link to guide, and removing redundant kwargs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2018
Merged

fixing docs badge, adding link to guide, and removing redundant kwargs #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2cd2de
fixing docs badge, adding link to guide, and removing redundant kwargs
Dec 5, 2018
0662098
space after library, revert URLs
brentru Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Introduction
============

.. image:: https://readthedocs.org/projects/adafruit-circuitpython-tinylora/badge/?version=latest
:target: https://circuitpython.readthedocs.io/projects/tinylora/en/latest/
.. image:: https://readthedocs.org/projects/circuitpython-tinylora/badge/?version=latest
:target: https://circuitpython-tinylora.readthedocs.io/en/latest/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this? If the URL provided by cookiecutter isn't working it means there's an issue on the RTD end that needs to be addressed. TinyLoRa documentation doesn't appear to have been setup properly in RTD. Please ping me for the proper process for this.

:alt: Documentation Status

.. image:: https://img.shields.io/discord/327254708534116352.svg
Expand Down Expand Up @@ -54,7 +54,9 @@ To install in a virtual environment in your current project:
Usage Example
=============

Usage example is described in the learn guide for this library.
Usage is described in the `learn guide for this library<https://learn.adafruit.com/using-lorawan-and-the-things-network-with-circuitpython>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing a space after library.




Contributing
============
Expand Down
2 changes: 1 addition & 1 deletion examples/tinylora_simpletest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
led = digitalio.DigitalInOut(board.D13)
led.direction = digitalio.Direction.OUTPUT

spi = busio.SPI(board.SCK, MISO=board.MISO, MOSI=board.MOSI)
spi = busio.SPI(board.SCK, board.MISO, board.MOSI)

# RFM9x Breakout Pinouts
cs = digitalio.DigitalInOut(board.D5)
Expand Down
2 changes: 1 addition & 1 deletion examples/tinylora_simpletest_si7021.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
sensor = adafruit_si7021.SI7021(i2c)

# Create library object using our bus SPI port for radio
spi = busio.SPI(board.SCK, MISO=board.MISO, MOSI=board.MOSI)
spi = busio.SPI(board.SCK, board.MISO, board.MOSI)

# RFM9x Breakout Pinouts
cs = digitalio.DigitalInOut(board.D5)
Expand Down