Skip to content

Update interrupt handling, fix white, and setup PyPi #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2019

Conversation

siddacious
Copy link
Contributor

The big change here is how the interrupts are being handled. I added cached_interrupt_state, _update_interrupt_state, and _get_and_clear_cached_interrupt_state to handle saving the interrupt state and modified the properties used to poll the interrupt state to use the cached copy.

This allows any interrupt status check to make sure it has the current interrupt status while not wiping out the state of other interrupts that haven't been polled yet.

@siddacious siddacious requested a review from a team June 25, 2019 22:05
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for catching the white issue. Well done on sorting the interrupts!

@kattni kattni merged commit 55a924e into adafruit:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants