Improve reset during initialization #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Looks good to me. I tested successfully with the simpletest + ethernet featherwing and a esp32 s3 TFT.
Thanks for the fixes @fasteddy516
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 18, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.2.3 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#32 from caternuson/iss31 Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.2 from 5.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#131 from fasteddy516/improved_reset Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #128. Closes #124. Improves the handling of the optional
resetpin by callingswitch_to_output()and increasing the delay at the end of the reset procedure.Tested with CircuitPython 8.2.0-rc.1 on a Raspberry Pi Pico with WIZnet Ethernet Hat (w5100s chipset).