Ignore last 2 bits of digital input, only on boards without long ints #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility on boards that don't support arbitrary integers. Bit 31 and 32 are scrubbed on these boards instead of throwing OverflowError, while builds with long ints retain this extra functionality.
|
Thank you! I updated the description of this PR to reflect that it closes the referenced bug. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 26, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.3.9 from 0.3.8: > Updated setup.py, reverted release.yml Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.11.2 from 1.10.12: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#108 from carlfj/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#109 from Neradoc/nera-fix-pixelbuf-size > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#106 from Neradoc/use-pixelbuf > Changed .env to .venv in README.rst > Removed duplicate-code from library pylint disable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility on boards that don't support arbitrary integers. Bit 31 and 32 are scrubbed on these boards instead of throwing OverflowError, while builds with long ints retain this extra functionality.
Previous version breaks functionality for boards like QT Py SAMD21 using NeoKey 1x4 QT I2C Breakout or ATSAMD09 Breakout with Seesaw. More details in comments of issue #107.
Closes: #107