Skip to content

use rainbowio for colorwheel #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

FoamyGuy
Copy link
Contributor

with CP 7 colorwheel is moved from _pixelbuf to rainbowio

I do not have the hardware necessary to test the full example. But I did test the imports on Trinket M0 7.0.0 alpha6 and confirmed that it does have rainbowio even though it doesn't have _pixelbuf so the fallback to adafruit_pixelbuf should not be necessary any more.

@FoamyGuy FoamyGuy requested a review from a team August 16, 2021 15:49
@tannewt
Copy link
Member

tannewt commented Aug 16, 2021

Shouldn't we wait to change this until 7.0.0 is stable? It won't work with 6.3.0 from what I can tell.

@kattni
Copy link
Contributor

kattni commented Aug 16, 2021

That was going to be my suggestion. We need to wait to update to rainbowio until 7 is stable.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we can merge this now!

@kattni kattni merged commit b9259da into adafruit:main Oct 7, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 13, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#29 from FoamyGuy/type_info
  > Globally disabled consider-using-f-string pylint check

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.2.2 from 6.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#119 from jsymons/typing
  > Globally disabled consider-using-f-string pylint check

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.0 from 1.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#85 from ladyada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#81 from FoamyGuy/use_rainbowio
  > Globally disabled consider-using-f-string pylint check

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.12.2 from 2.12.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#69 from careyk007/add_missing_type_annotations
  > Globally disabled consider-using-f-string pylint check

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.2 from 1.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#27 from helgibbons/Display-Pack-2.0
  > Globally disabled consider-using-f-string pylint check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants