Skip to content

Burning Fire Wizard Staff Code #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 16, 2020
Merged

Burning Fire Wizard Staff Code #1056

merged 10 commits into from
Mar 16, 2020

Conversation

firepixie
Copy link
Collaborator

added project .zip file

@kattni
Copy link
Contributor

kattni commented Mar 16, 2020

@ladyada The linter is failing on code unrelated to this PR. The code in this PR is now passing.

Using config file /home/travis/build/adafruit/Adafruit_Learning_System_Guides/.pylintrc
************* Module code
NeoPixel_Badge_Lanyard/code.py 114: Trailing whitespace (trailing-whitespace)
------------------------------------
Your code has been rated at 10.00/10
The command "./pylint_check" exited with 123.```

@ladyada
Copy link
Member

ladyada commented Mar 16, 2020

@kattni ok please also fix that py file in this commit

@kattni kattni self-requested a review March 16, 2020 16:55
@kattni
Copy link
Contributor

kattni commented Mar 16, 2020

@ladyada The trailing whitespace in the badge lanyard code was added within this PR. I noticed this finally after trying to figure out how to PR to this PR. Fix is made in this PR.

@firepixie Please make sure when you create a PR that the files included are only the files you intend to include in the PR. Somehow a space was added to another file and submitted as a change with this PR.

@kattni kattni requested a review from ladyada March 16, 2020 17:52
@ladyada ladyada merged commit 1b18cfc into adafruit:master Mar 16, 2020
@ladyada
Copy link
Member

ladyada commented Mar 16, 2020

huzzah great teamwork :) thanks for the fix @kattni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants