Skip to content

Update clue_step_counter.py #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Update clue_step_counter.py #1217

merged 1 commit into from
Aug 22, 2020

Conversation

dglaude
Copy link
Contributor

@dglaude dglaude commented Aug 22, 2020

Fix for the change in adafruit_lsm6ds.
This has been tested on my Clue.

Fix for the change in adafruit_lsm6ds.
@ladyada ladyada requested a review from BlitzCityDIY August 22, 2020 00:17
@BlitzCityDIY
Copy link
Collaborator

Hello, I updated to the most recent libraries but unfortunately keep getting this error, unless I should be using a different build?:

Traceback (most recent call last):
File "code.py", line 1, in
File "adafruit_clue.py", line 968, in
File "adafruit_clue.py", line 241, in init
AttributeError: 'module' object has no attribute 'LSM6DS33'

@dglaude
Copy link
Contributor Author

dglaude commented Aug 22, 2020

Ok, my fix is for direct problem introduced by lsm6ds change.
It is not for the indirect problem in the CLUE library.
So it may seems not to work for you, but it is still the correct course of action.

I am adapting to the change in adafruit_lsm6ds that is available in this bundle: adafruit-circuitpython-bundle-6.x-mpy-20200821 (easy, it goes from a single *.mpy file in 20200820 to a folder in 20200821).

For my test I used the CLUE library as a adafruit_clue.py file with the following PR applied: adafruit/Adafruit_CircuitPython_CLUE#33

I don't know when that version of the adafruit_clue.mpy will be available in the bundle... but I suggest the sooner the better.

@BlitzCityDIY
Copy link
Collaborator

Oh cool, just tested with that PR for the clue library and it is working, thanks!

Copy link
Collaborator

@BlitzCityDIY BlitzCityDIY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working with updated PR for adafruit_clue library

@ladyada
Copy link
Member

ladyada commented Aug 22, 2020

thanks for fixing @dglaude & thanks for testing @BlitzCityDIY

@ladyada ladyada merged commit c439726 into adafruit:master Aug 22, 2020
@dglaude dglaude deleted the patch-4 branch August 22, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants