Moved audioio.WaveFile -> audiocore.WaveFile #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't ever done a whole lot with audio, so there were a lot of projects that I couldn't test since I didn't have the hardware, but here's what I did test:
If you'd like me to test more, I can see about grabbing a crickit and a propmaker featherwing since a majority of the projects I modified use one of those. |
ladyada
approved these changes
Jan 12, 2021
|
im ok with that, @tannewt any thoughts? |
|
I was going to submit exactly the same fix for a single one of these, then discovered this PR. Very happy this is being done. |
tannewt
reviewed
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved audioio.RawSample -> audiocore.RawSample
Fixes #1342