Skip to content

Matrix Portal Moon Clock fix for Circuitpython 7 #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Oct 25, 2021

time.struct_time() in 7.0.0 no longer accepts 9 arguments, it now only works with a single 9-elements tuple (PR 4931).
Using a single 9-tuple should remain compatible with 6.3.0 (did not test).

`time.struct_time()` in 7.0.0 no longer accepts 9 arguments, it now only works with a single 9-elements tuple. (PR 4931).
Using a single 9-tuple should be compatible with 6, so this fix should remain compatible with 6.3.0 (did not test).
@dhalbert
Copy link
Contributor

This looks good to me. It doesn't work with 9 args in CPython either.

Python 3.8.10 (default, Sep 28 2021, 16:10:42) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import time
>>> time.struct_time(1,2,3,4,5,6,7,8,9)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: structseq() takes at most 2 arguments (9 given)
>>> time.struct_time((1,2,3,4,5,6,7,8,9))
time.struct_time(tm_year=1, tm_mon=2, tm_mday=3, tm_hour=4, tm_min=5, tm_sec=6, tm_wday=7, tm_yday=8, tm_isdst=9)
>>> time.struct_time(tm_year=1, tm_mon=2, tm_mday=3, tm_hour=4, tm_min=5, tm_sec=6, tm_wday=7, tm_yday=8, tm_isdst=9)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: structseq() takes at most 2 keyword arguments (9 given)

@PaintYourDragon PaintYourDragon merged commit a544133 into adafruit:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants