Skip to content

first commit doorbell #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

jedgarpark
Copy link
Contributor

Feather RP2040 + Crickit + Gemmy Animated Eyeball Doorbell with custom audio files and animation.

@jedgarpark jedgarpark requested a review from TheKitty November 6, 2021 01:38
Copy link
Collaborator

@TheKitty TheKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a pylint error. Also please remove the project name in the SPDX-FileCopyrightText line, only year, your name and for Adafruit Industries please

@jedgarpark
Copy link
Contributor Author

@TheKitty weird, I'm getting 10.00/10 on pylint. Maybe my pylint is out of date? What errors did it throw?

@TheKitty
Copy link
Collaborator

TheKitty commented Nov 7, 2021

Using pylint bin at /opt/hostedtoolcache/Python/3.6.15/x64/bin/pylint
************* Module code
Crickit_Animatronic_Doorbell/code.py 8: standard import "import random" should be placed before "import board" (wrong-import-order)

@jedgarpark
Copy link
Contributor Author

Using pylint bin at /opt/hostedtoolcache/Python/3.6.15/x64/bin/pylint ************* Module code Crickit_Animatronic_Doorbell/code.py 8: standard import "import random" should be placed before "import board" (wrong-import-order)

@TheKitty ah, ok I had gotten that error and fixed it, but must not have re-saved before committing. Thanks for the help.

@jedgarpark jedgarpark merged commit 8eed36b into adafruit:main Nov 8, 2021
@jedgarpark jedgarpark deleted the animatronic-doorbell branch November 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants