Skip to content

reduced polyphony lag #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Conversation

jedgarpark
Copy link
Contributor

Code was lagging when four notes were played in rapid succession. Added 'while macropad.keys.events:' loop and turned off display auto refresh, instead refreshing once per loop. Note, 5-6 note polyphony still can lag, due probably to hitting the macropad max key event queue. This can probably be solved by using keypad instead of macropad, but that is beyond the scope of the MacroPad main guide examples.

Copy link
Collaborator

@TheKitty TheKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ladyada ladyada merged commit f8d3576 into adafruit:main Feb 27, 2022
@jedgarpark jedgarpark deleted the macropad-midi-tester branch February 28, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants