Fix order of days of the week #2192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
this is due to the RTC having sunday == 0, but wday having monday==0 https://docs.python.org/3/library/time.html (which honestly i kinda disagree with but we're stuck with i suppose :D )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the order of days is incorrect in some of the guides, I think due to the change made to
adafruit_regester.i2c_bcd_datetime.BCDDateTimeRegister.__get__(), which fixed the order of week days to be CPython compatible. This mirrors the change made in adafruit/Adafruit_CircuitPython_DS1307#27 and other similar libraries.None of these guides need to be updated for content.
Did not test.