Skip to content

Portal eyes: TileGrid has its own height property now #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2022
Merged

Portal eyes: TileGrid has its own height property now #2200

merged 1 commit into from
Jun 20, 2022

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Jun 20, 2022 •
edited
Loading

Don't try to set the height property of Sprite, because it now inherits it from displayio.TileGrid.

Without that change we get the following error in CP 7.2.0 and later:

Traceback (most recent call last):
  File "code.py", line 68, in <module>
  File "code.py", line 56, in __init__
AttributeError: 'Sprite' object has no attribute 'height'

@Neradoc
Portal eyes: TileGrid has its own height property now
d645ce4 
Don't try to set the height property of Sprite, because [it now inherits it from displayio.TileGrid](adafruit/circuitpython#5749).
@TheKitty TheKitty merged commit 14ef30f into adafruit:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKitty TheKitty TheKitty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neradoc @TheKitty