Skip to content

Make the CPX Simple Simon compatible with CPB #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Dec 31, 2022

This makes the code for the Circuit Playground Simple Simon compatible with the CPB.
I don't think there is another version of it that already works ?
https://learn.adafruit.com/circuit-playground-simple-simon/code-walk-through

  • use cp not cpx from the adafruit_circuitplayground library
  • do not read the analog pin A7 (not available on CPB)
  • reference cp.touch_TX (available on both) instead of cp.touch_A7

Also:

  • fix the call to game_lost() which takes a step and not a sequence[setp]
  • use a context manager to setup and deinit the analog pins
  • some spaces at the end of lines

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Does the guide text need updating?

@dhalbert dhalbert merged commit d28a258 into adafruit:main Dec 31, 2022
@dhalbert
Copy link
Contributor

Does the guide text need updating?

I updated the guide text: just needed to change the alert that said it only works on CPX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants