Update MEMENTO Facial Detection/Recognition Files

[brentru]

• Removes .task.json and merge_bin.py scripts from project, not required
• Removes zip file used for the project and switches to a folder so users can examine main.cpp from within GitHub. Will update learn element to zip the folder

[brentru]

@TheKitty // SPDX-FileCopyrightText: and // SPDX-License-Identifier: both exist across the files the SPDX checker is rasing errors for.

[TheKitty]

Apparently it's complaining about some missing license files - perhaps the SPDX licenses are not in the table of SPDX allowed values. Please cross-check with https://spdx.org/licenses/ Also I'm unsure who wrote the SPDX validation tool.

[brentru]

Please cross-check with https://spdx.org/licenses/

I'll take a look, thank you

Also I'm unsure who wrote the SPDX validation tool.

Looks like Eva did, https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/main/SPDX.py#L1

[TheKitty]

Yes, a look makes it seem that the licenses for those files are not SPDX compliant (close though)

…

On Fri, Feb 9, 2024 at 1:51 PM Brent Rubell ***@***.***> wrote: Please cross-check with https://spdx.org/licenses/ I'll take a look, thank you Also I'm unsure who wrote the SPDX validation tool. Looks like Eva did, https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/main/SPDX.py#L1 — Reply to this email directly, view it on GitHub <#2729 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOSY4HW5QCRJHATBZXM53DYSZV23AVCNFSM6AAAAABDBZ662SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGQ2DAMJVGA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

-- Anne Barela Engineer, Adafruit Industries ***@***.***

[tyeth]

Looks good

[brentru]

@TheKitty I've updated the licenses to match the list.

The tool keeps throwing:

Missing files: ['LICENSES/BSD-2-Claus.txt']

but that file sits within https://github.com/brentru/Adafruit_Learning_System_Guides/tree/main/LICENSES

and none of these files use the "claus" vs "clause" spelling, not sure where it's picking it up from..:

[TheKitty]

Is it possible Eva's code is only checking the first 20 characters of the file and not more?

[tyeth]

Is it possible Eva's code is only checking the first 20 characters of the file and not more?

yeah it seems like there was some legacy pattern matching, probably stripping trailing windows/line character. Not sure I've seen enough SPDX license lines to know what's expected. This offending line line.split("SPDX-License-Identifier: ")[1][:-1] should probably just trim/strip instead of [:-1], unless is that for a trailing date removal or something? It doesn't quite fit into the spec to just drop the end https://spdx.dev/learn/handling-license-info/#:~:text=SPDX%20IDs%3A%20How%20to%20use

[brentru]

@TheKitty @tyeth is right, the [:-1] at the end would turn the string BSD-2-Clause into BSD-2-Claus, which is not a valid file within LICENSES/.

I have added a check for this on the latest commit, dropping the check at the end and adding a strip() for extraneous whitespace.

Anne, If you agree that this is OK, please merge in.