Skip to content

Secrets Cleanup: P Part 1 #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Apr 1, 2025

@justmobilize justmobilize force-pushed the secrets-cleanup-p-part1 branch from 662172b to f237410 Compare April 1, 2025 14:07
@justmobilize
Copy link
Contributor Author

@FoamyGuy here's the first 1/3 or PyPortal... All pretty strait forward

@justmobilize justmobilize marked this pull request as ready for review April 2, 2025 16:06
@TheKitty
Copy link
Collaborator

TheKitty commented Apr 2, 2025

If you notice any PyPortal programs not in the Learn PyPortal subdirectory, it would be good to move them in and update the guide.

@justmobilize
Copy link
Contributor Author

If you notice any PyPortal programs not in the Learn PyPortal subdirectory, it would be good to move them in and update the guide.

Would you think just ones that have from adafruit_pyportal import PyPortal? If so there are two:

  • CircuitPython_Logger\aio_test\code.py
  • Twitter_API\code.py

here are all the ones that mention PyPortal, but not in the folder:
image

Happy to move any of them in my next PRs

@TheKitty
Copy link
Collaborator

TheKitty commented Apr 2, 2025 via email

@justmobilize
Copy link
Contributor Author

Sounds good. Any I see that are obvious I'll move in the next PRs (as you can see I have some with changes, and will move those when I submit those. Trying not to overload Tim)

@TheKitty
Copy link
Collaborator

TheKitty commented Apr 2, 2025 via email

@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Apr 8, 2025

I've looked all of the code changes here, aside from the changes noted for CMA art, and the question bout testing the election pyportal one, everything here looks good to me. I'll come back and do the learn page changes and check them off the list above once those are settled.

- fix PyPortal_CMA_Art_Frame
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an incompatibility with settings.toml vs. secrets.py while updating the guide pages.

…key to placeholder settings.toml for halloween countdown.
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. I added a commit with the remaining requested changes.

There are two guide pages that I'll need to circle back to after merging this. I'll add another comment here once everything is complete.

I looked for the "cannot find" ones and also came up empty on all of them.

@FoamyGuy FoamyGuy merged commit 071c95b into adafruit:main Apr 9, 2025
4 checks passed
@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Apr 9, 2025

All learn guide page updates are completed for this batch.

@justmobilize justmobilize deleted the secrets-cleanup-p-part1 branch April 9, 2025 17:03
@justmobilize justmobilize mentioned this pull request Apr 9, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants