-
Notifications
You must be signed in to change notification settings - Fork 789
Secrets Cleanup: P Part 1 #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
662172b
to
f237410
Compare
@FoamyGuy here's the first 1/3 or PyPortal... All pretty strait forward |
If you notice any PyPortal programs not in the Learn PyPortal subdirectory, it would be good to move them in and update the guide. |
Any that are based on the hardware PyPortal (and Titano and Pynt) would be
candidates, yes.
I would appreciate very much if they were moved under the PyPortal
directory with fixups to guides.
Thanks so much!
And that would apply to any projects that also have subdirectories made.
The "odd ones" take up a great deal of time to track down, so the more
folks that are looking the more we can find and rectify which frees up
directory slots in the main Learn repo (GitHub limits to 1000 entries).
…On Wed, Apr 2, 2025 at 11:24 AM Justin Myers ***@***.***> wrote:
If you notice any PyPortal programs not in the Learn PyPortal
subdirectory, it would be good to move them in and update the guide.
Would you think just ones that have from adafruit_pyportal import PyPortal?
If so there are two:
- CircuitPython_Logger\aio_test\code.py
- Twitter_API\code.py
here are all the ones that mention PyPortal, but not in the folder:
image.png (view on web)
<https://github.com/user-attachments/assets/766fc42d-84ec-474c-9a90-155568204550>
Happy to move any of them in my next PRs
—
Reply to this email directly, view it on GitHub
<#3004 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOSY4HTU2BZTZPWAWGX3ND2XQFLXAVCNFSM6AAAAAB2HACUOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGEYTEMZZGI>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
[image: justmobilize]*justmobilize* left a comment
(adafruit/Adafruit_Learning_System_Guides#3004)
<#3004 (comment)>
If you notice any PyPortal programs not in the Learn PyPortal
subdirectory, it would be good to move them in and update the guide.
Would you think just ones that have from adafruit_pyportal import PyPortal?
If so there are two:
- CircuitPython_Logger\aio_test\code.py
- Twitter_API\code.py
here are all the ones that mention PyPortal, but not in the folder:
image.png (view on web)
<https://github.com/user-attachments/assets/766fc42d-84ec-474c-9a90-155568204550>
Happy to move any of them in my next PRs
—
Reply to this email directly, view it on GitHub
<#3004 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOSY4HTU2BZTZPWAWGX3ND2XQFLXAVCNFSM6AAAAAB2HACUOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGEYTEMZZGI>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
--
Anne Barela
Engineer, Adafruit Industries
***@***.***
|
Sounds good. Any I see that are obvious I'll move in the next PRs (as you can see I have some with changes, and will move those when I submit those. Trying not to overload Tim) |
Yes, only if the bandwidth isn't high. The main task is most important.
…On Wed, Apr 2, 2025 at 11:48 AM Justin Myers ***@***.***> wrote:
Sounds good. Any I see that are obvious I'll move in the next PRs (as you
can see I have some with changes, and will move those when I submit those.
Trying not to overload Tim)
—
Reply to this email directly, view it on GitHub
<#3004 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOSY4DQMEZVZHQIBW4VJE32XQIFNAVCNFSM6AAAAAB2HACUOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGE3DOMBVGM>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
[image: justmobilize]*justmobilize* left a comment
(adafruit/Adafruit_Learning_System_Guides#3004)
<#3004 (comment)>
Sounds good. Any I see that are obvious I'll move in the next PRs (as you
can see I have some with changes, and will move those when I submit those.
Trying not to overload Tim)
—
Reply to this email directly, view it on GitHub
<#3004 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOSY4DQMEZVZHQIBW4VJE32XQIFNAVCNFSM6AAAAAB2HACUOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGE3DOMBVGM>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
--
Anne Barela
Engineer, Adafruit Industries
***@***.***
|
I've looked all of the code changes here, aside from the changes noted for CMA art, and the question bout testing the election pyportal one, everything here looks good to me. I'll come back and do the learn page changes and check them off the list above once those are settled. |
- fix PyPortal_CMA_Art_Frame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an incompatibility with settings.toml vs. secrets.py while updating the guide pages.
…key to placeholder settings.toml for halloween countdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. I added a commit with the remaining requested changes.
There are two guide pages that I'll need to circle back to after merging this. I'll add another comment here once everything is complete.
I looked for the "cannot find" ones and also came up empty on all of them.
All learn guide page updates are completed for this batch. |
Uh oh!
There was an error while loading. Please reload this page.