Update CircuitPython_I2S_Tone.py #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed issue with sine wave calculation where changing the frequency did not have the correct result * The DC offset would change based on the `tone_volume` var, now it is constant at `2**15-1`. * Added sample rate variable to make sine wave generation more parametric.
|
The lint program is complaining line 14 is > 79 chars (111). Try to use a continuation line with the correct indent or comment marks to have lines <= 80 chars (yeah, the linter is picky). |
Added continuation line for sine wav calculation to avoid PEP8 issue.
fixed trailing white space issue
|
thanks @TheKitty, I think I figured out how to get through PEP8 adding a continuation line. The original line was also too long. |
kattni
approved these changes
Mar 6, 2019
|
Verified that guide does not need to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tone_volumevar, now it is constant at2**15-1.