Skip to content

PyPortal NASA image viewer #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

kevinjwalters
Copy link
Contributor

@kevinjwalters kevinjwalters commented May 30, 2019

There are two changes here:

  1. Retrieving the NASA API key from secrets.py
  2. Using a new feature in adafruit_pyportal to post-process JSON responses from NASA to convert any YouTube videos into a url for a still image.

The first requires documentation updates to:

The second must not be "released" until the

The code to do the YouTube conversion might be better one day placed in a library of "converters".

@tannewt tannewt requested a review from jedgarpark July 8, 2019 01:30
kevinjwalters pushed a commit to kevinjwalters/Adafruit_Learning_System_Guides that referenced this pull request Nov 8, 2019
kevinjwalters pushed a commit to kevinjwalters/Adafruit_Learning_System_Guides that referenced this pull request Nov 8, 2019
kevinjwalters pushed a commit to kevinjwalters/Adafruit_Learning_System_Guides that referenced this pull request Nov 8, 2019
@kevinjwalters
Copy link
Contributor Author

https://github.com/adafruit/Adafruit_CircuitPython_PyPortal/tree/3.1.3 is latest at the moment and does not have the json_transform enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant