Skip to content

Update Snow_Globe_BLE_CPB for CP 5.0 Beta _bleio #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Update Snow_Globe_BLE_CPB for CP 5.0 Beta _bleio #950

merged 7 commits into from
Dec 3, 2019

Conversation

jerryneedell
Copy link
Collaborator

Updated for new API
revised the way advertising is started/restarted to avoid errors
also set the default shake threshold to 20 ( was 27 and hard to get it to respond)
Tested on CPB

@jerryneedell
Copy link
Collaborator Author

jerryneedell commented Dec 1, 2019

hmm any suggestions on how to fix this to make Travis happy?
Should I just add #pylint:disable=protected-access ?

319.45s$ ./pylint_check
1135Using config file /home/travis/build/jerryneedell/Adafruit_Learning_System_Guides/.pylintrc
1136************* Module ble_snowglobe
1137Snow_Globe_BLE_CPB/ble_snowglobe.py 51: Access to a protected member _adapter of a client class (protected-access)
1138
1139------------------------------------
1140Your code has been rated at 10.00/10
1141
1142The command "./pylint_check" exited with 123.
114365.45s$ build_main_platforms
1144
1145

Copy link

@KingerNorth KingerNorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes made by jerryneedell and all of it is working. The name does display after the 1st connect as expected.

Copy link

@KingerNorth KingerNorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@dhalbert
Copy link
Contributor

dhalbert commented Dec 1, 2019

@jerryneedell Add #pylint: disable=protected-access to the offending line.

@dhalbert
Copy link
Contributor

dhalbert commented Dec 1, 2019

Try putting the #pylint: as a comment on the same line. That will restrict the scope to that line.

@dhalbert
Copy link
Contributor

dhalbert commented Dec 1, 2019

you can try running pylint locally :). Copy the command line from .travis.yml

@jerryneedell
Copy link
Collaborator Author

Sorry -- When I do I get lots of error for Guides , but I may just need to re-install it.

@jerryneedell
Copy link
Collaborator Author

jerryneedell commented Dec 1, 2019

Travis keep failing well beyond the pylint checks -- please let me know what I can do to fix it.
https://travis-ci.com/adafruit/Adafruit_Learning_System_Guides

1210
1211fork/exec /bin/xtensa-lx106-elf-g++: no such file or directory
1212
1213

it passed when it ran on my fork...
https://travis-ci.com/jerryneedell/Adafruit_Learning_System_Guides

@ladyada
Copy link
Member

ladyada commented Dec 1, 2019

@dhalbert @jerryneedell when you see these errors you need to delete travis caches

Copy link
Contributor

@jedgarpark jedgarpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, tested in a snow globe.

@dhalbert dhalbert merged commit c048d1a into adafruit:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants