-
Notifications
You must be signed in to change notification settings - Fork 789
Update Snow_Globe_BLE_CPB for CP 5.0 Beta _bleio #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm any suggestions on how to fix this to make Travis happy?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes made by jerryneedell and all of it is working. The name does display after the 1st connect as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
@jerryneedell Add |
Try putting the |
you can try running pylint locally :). Copy the command line from .travis.yml |
Sorry -- When I do I get lots of error for Guides , but I may just need to re-install it. |
Travis keep failing well beyond the pylint checks -- please let me know what I can do to fix it.
it passed when it ran on my fork... |
@dhalbert @jerryneedell when you see these errors you need to delete travis caches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, tested in a snow globe.
Updated for new API
revised the way advertising is started/restarted to avoid errors
also set the default shake threshold to 20 ( was 27 and hard to get it to respond)
Tested on CPB