Skip to content

Create appropriate readme for new guide #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2020
Merged

Conversation

TheKitty
Copy link
Collaborator

@TheKitty TheKitty commented Jan 6, 2020

No description provided.

Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved once linted

@TheKitty
Copy link
Collaborator Author

TheKitty commented Jan 6, 2020

Thank you @ladyada

@TheKitty TheKitty merged commit 8d3236e into master Jan 6, 2020
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheKitty I looked at this file since it used minimqtt and I was interested in what Richard was doing with it - req'ing two small changes after travis passes..

display = board.DISPLAY

# Backlight function
def set_backlight(val):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheKitty This is defined but never used in code, pls remove.

i2c_bus = busio.I2C(board.SCL, board.SDA)
adt = adafruit_adt7410.ADT7410(i2c_bus, address=0x48)
adt.high_resolution = True
temperature = "blaa"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set this to 0

@dhalbert dhalbert deleted the TheKitty-patch-114 branch December 30, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants