Skip to content

Update .gitignore to include more build artifacts. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

No description provided.

@jposada202020
Copy link
Contributor

@lesamouraipourpre just to understand, this will include artifacts when doing a PR and when releasing ?
Is there a way that I could test this? I have some libraries in the community bundle, so I could test with those.

Lt me know

Thanks for this :)

@lesamouraipourpre
Copy link
Contributor Author

After doing the build locally with .build.sh and running git status:

On branch master
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        build-circuitpython-community-bundle-6.x-mpy-20210506.zip/
        build-circuitpython-community-bundle-7.x-mpy-20210506.zip/
        build-circuitpython-community-bundle-examples-20210506.zip/
        build-circuitpython-community-bundle-py-20210506.zip/
        build_deps/

There is no need to upload these new build artifacts to github. That is what this change to .gitignore will prevent.

@jposada202020
Copy link
Contributor

Understood.. will do. Thanks again

Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes this two directories are created when building the library. While creating the community bundle, these two directories are created.

@jposada202020 jposada202020 merged commit 46cd22e into adafruit:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants