enable selection of polling rate #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
This is fine. But the style of how various values are represented is odd. Integers are passed in (instead of named constants). They are then checked against some named constants, and then converted back to the internal integer register values.
It would have been better if only the named constants could be passed in. They could be type-checked, and then their values would just be used to set the register values.
|
My only concern is with the use of f-string formatting within a common CircuitPython library. F-strings are not implemented on limited-memory boards like the M0 if I understand correctly. |
|
f-strings are now everywhere, as of 8.1.0 |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 29, 2023
Updating https://github.com/adafruit/CircuitPython_NAU7802 to 2.1.1 from 2.0.0: > Merge pull request adafruit/CircuitPython_NAU7802#11 from JohnHind/main > Merge pull request adafruit/CircuitPython_NAU7802#10 from semininja/main Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.15.0 from 1.14.13: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#81 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
adafruit-adabot
added a commit
to adafruit/CircuitPython_Community_Bundle
that referenced
this pull request
Nov 29, 2023
Updating https://github.com/Uberi/biplane to 1.0.4 from 1.0.2: > Add check for malformed unicode, move tests out of top level Updating https://github.com/CedarGroveStudios/CircuitPython_NAU7802 to 2.1.1 from 2.0.0: > Merge pull request adafruit/CircuitPython_NAU7802#11 from JohnHind/main > Merge pull request adafruit/CircuitPython_NAU7802#10 from semininja/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that this was partially implemented, and it looked fairly straightforward to put in the rest.