Skip to content

Doc/update readme #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jul 9, 2022

Resolves #16 by updating README

@tekktrik tekktrik requested a review from makermelissa July 9, 2022 18:47
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a couple of questions regarding some changes that I don't understand the reasoning behind. Thanks.

@@ -4,7 +4,7 @@

repos:
- repo: https://github.com/fsfe/reuse-tool
rev: latest
rev: v0.14.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind changing this to v0.14.0? I may have missed some conversation about this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error when trying to use "latest" locally, so I instead pinned it to the latest version the libraries use, but I can double check to see if I misunderstood.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. What are the other repos doing for this?

Copy link
Member Author

@tekktrik tekktrik Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other repos are pinning to this version (v0.14.0) of the reuse hook.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool. Thanks for double checking. Looks good.

@makermelissa makermelissa merged commit 61f803d into adafruit:master Jul 11, 2022
@tekktrik tekktrik deleted the doc/update-readme branch February 14, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README
2 participants