Install optional requirements if available #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Took me a minute to follow this change. This makes a lot of sense. Good catch on realising this step would need to be done!
I'll leave it up to you as to when to merge this. If it's not interfering with anything else, I would say we can merge it now.
Also, it may be worth merging this now, manually updating one library with optional requirements, merging that PR, and making sure it all works together.
|
Sounds good, I'll merge this now then and target a library with optional dependencies. Thanks y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan for switching to
pyproject.tomlis useoptional_requirements.txtto hold optional dependencies for libraries. This may be an issue for things like building documentation and pylint, so this additional step checks for the file and pip installs it so.While I don't think it would cause any issues if rolled out, this is totally fine as a draft PR until
pyproject.tomlgets rolled out, but wanted to get eyes on it early!