Skip to content

Update package metadata before installing packages #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Mar 2, 2020

On Discord, @FoamyGuy mentioned that some builds were failing at the "install deps" step with a message like:

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/s/systemd/libudev-dev_237-3ubuntu10.33_amd64.deb  404  Not Found [IP: 52.177.174.250 80]

This kind of error can occur when the package metadata is out of date and this specific package version was superseded by another in a security update.

Ideally, the image supplied by github would always be up to date, but if it's not, then doing the "update" will ensure that the metadata is right at the cost of probably just 1-2s of runtime.

(I intended to submit this patch a few weeks ago but accidentally opened a PR against my fork instead, whoops!)

On Discord, @FoamyGuy mentioned that some builds were failing at the "install deps" step with a message like:
```
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/s/systemd/libudev-dev_237-3ubuntu10.33_amd64.deb  404  Not Found [IP: 52.177.174.250 80]
```
This kind of error can occur when the package metadata is out of date and this specific package version was superseded by another in a security update.

Ideally, the image supplied by github would always be up to date, but if it's not, then doing the "update" will ensure that the metadata is right at the cost of probably just 1-2s of runtime.
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt tannewt merged commit d95b4ae into adafruit:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants