Skip to content

Commit dc7498f

Browse files
tannewttannewt
authored
Merge pull request #194 from jwcooper/accessibility
Accessibility Changes
2 parents 1f10283 + 21097ea commit dc7498f

File tree

14 files changed

+284
-312
lines changed

14 files changed

+284
-312
lines changed

‎Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ gem "jekyll", "~> 3.8.4"
1818
# If you have any plugins, put them here!
1919
group :jekyll_plugins do
2020
gem 'jekyll-sitemap'
21-
gem 'jekyll-feed'
2221
gem 'jekyll-seo-tag'
2322
gem 'jekyll-paginate'
2423
end

‎Gemfile.lock

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ GEM
2727
pathutil (~> 0.9)
2828
rouge (>= 1.7, < 4)
2929
safe_yaml (~> 1.0)
30-
jekyll-feed (0.11.0)
31-
jekyll (~> 3.3)
3230
jekyll-paginate (1.1.0)
3331
jekyll-sass-converter (1.5.2)
3432
sass (~> 3.4)
@@ -65,7 +63,6 @@ PLATFORMS
6563

6664
DEPENDENCIES
6765
jekyll (~> 3.8.4)
68-
jekyll-feed
6966
jekyll-paginate
7067
jekyll-seo-tag
7168
jekyll-sitemap

‎_includes/download/blinka.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h3>Adafruit Blinka Installation</h3>
1212
so much because they all happen underneath the adafruit_blinka layer.
1313
</p>
1414
<div>
15-
<a class="download-button" href="{{ page.download_instructions }}">INSTALLATION INSTRUCTIONS<i class="fas fa-arrow-circle-right"></i></a>
15+
<a class="download-button" href="{{ page.download_instructions }}">INSTALLATION INSTRUCTIONS<i class="fas fa-arrow-circle-right" aria-hidden="true"></i></a>
1616
<div class="clear"></div>
1717
</div>
1818
</div>

‎_includes/download/board.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ <h3>CircuitPython {{ version.version }}</h3>
5555
</label>
5656
<div class="download-buttons">
5757
{% for file in version.files['en_US'] %}
58-
<a class="download-button {% if version.stable %}stable{% else %}unstable{% endif %} {{ file | slice: -3, 3 }}" href="{{ file }}">DOWNLOAD {{ file | slice: -4, 4 | upcase }} NOW <i class="fas fa-download"></i></a>
58+
<a class="download-button {% if version.stable %}stable{% else %}unstable{% endif %} {{ file | slice: -3, 3 }}" href="{{ file }}">DOWNLOAD {{ file | slice: -4, 4 | upcase }} NOW <i class="fas fa-download" aria-hidden="true"></i></a>
5959
{% endfor %}
6060
</div>
6161
</div>
@@ -70,7 +70,7 @@ <h3>Absolute Newest</h3>
7070
the absolute latest and are feeling risky.
7171
</p>
7272
<div>
73-
<a class="download-button-unrecommended" href="https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/{{ page.board_id }}/">BROWSE S3<i class="fas fa-arrow-circle-right"></i></a>
73+
<a class="download-button-unrecommended" href="https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/{{ page.board_id }}/">BROWSE S3<i class="fas fa-arrow-circle-right" aria-hidden="true"></i></a>
7474
<div class="clear"></div>
7575
</div>
7676
</div>
@@ -81,7 +81,7 @@ <h3>Past Releases</h3>
8181
the latest stable otherwise.
8282
</p>
8383
<div>
84-
<a class="download-button-unrecommended" href="https://github.com/adafruit/circuitpython/releases">BROWSE GITHUB<i class="fab fa-github"></i></a>
84+
<a class="download-button-unrecommended" href="https://github.com/adafruit/circuitpython/releases">BROWSE GITHUB<i class="fab fa-github" aria-hidden="true"></i></a>
8585
<div class="clear"></div>
8686
</div>
8787
</div>

‎_layouts/default.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!DOCTYPE html>
2-
<html>
2+
<html lang="en">
33

44
{% include head.html %}
55

‎_layouts/post.html

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎assets/javascript/downloads.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ function shouldDisplayDownload(download, displayedManufacturers, displayedFeatur
326326
}
327327

328328
function appendFilterTag(type, name) {
329-
var tagHtml = "<span class='tag'><i class='fas fa-times tag-remove' ";
329+
var tagHtml = "<span class='tag'><i class='fas fa-times tag-remove' title='Remove Filtered Option'";
330330
tagHtml += "data-type='" + type + "' ";
331331
tagHtml += "data-name='" + name + "'></i>";
332332
tagHtml += name + "</span>";

‎assets/sass/base/_base.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,12 @@ a.purple-button-link {
3333
padding-left: 10px;
3434
}
3535
}
36+
37+
fieldset {
38+
border: 0;
39+
40+
legend {
41+
font-size: 1.5em;
42+
font-weight: 500;
43+
}
44+
}

‎assets/sass/pages/_home.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010
}
1111

1212
.content {
13-
h1 {
13+
h2 {
1414
width: 75%;
1515
margin: 20px auto;
16+
font-size: 2em;
1617
}
1718

1819
p {

‎blinka.html

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,34 +9,41 @@ <h1>Blinka</h1>
99
<div class="downloads-inputs">
1010
<div class="downloads-search">
1111
<label class="search-wrapper">
12-
<input type="text" id="search" placeholder="Search for CircuitPython boards" />
12+
<input aria-label="Search for Blinka boards" type="text" id="search" placeholder="Search for Blinka boards" />
1313
</label>
1414
</div>
1515
<div class="downloads-filter">
16-
<button class="filter"><i class="fas fa-sliders-h"></i></button>
16+
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h" aria-hidden="true"></i></button>
1717
</div>
1818
<div class="downloads-filter-tags">
1919
</div>
2020
</div>
2121
<div class="downloads-filter-content">
2222
<div class="filter-buttons">
23-
<button class="save-changes"><i class="fas fa-times"></i></button>
23+
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times" aria-hidden="true"></i></button>
2424
</div>
2525
<div>
2626
<div class="manufacturers">
27-
<h2>Manufacturers</h2>
28-
<ul class="content"></ul>
27+
<fieldset>
28+
<legend>Manufacturers</legend>
29+
<ul class="content"></ul>
30+
</fieldset>
2931
</div>
3032
<div class="features">
31-
<h2>Features</h2>
32-
<ul class="content"></ul>
33+
<fieldset>
34+
<legend>Features</legend>
35+
<ul class="content"></ul>
36+
</fieldset>
3337
</div>
3438
<div class="sort-by">
35-
<h2>Sort By</h2>
36-
<ul class="content">
37-
<li><input type="radio" name="sort-by" value="alpha-asc" checked> Board Name (A to Z)</li>
38-
<li><input type="radio" name="sort-by" value="alpha-desc"> Board Name (Z to A)</li>
39-
</ul>
39+
<fieldset>
40+
<legend>Sort By</legend>
41+
<ul class="content">
42+
<li><input type="radio" name="sort-by" value="downloads" aria-label="Downloads" checked> Downloads</li>
43+
<li><input type="radio" name="sort-by" value="alpha-asc" aria-label="Board Name (A to Z)"> Board Name (A to Z)</li>
44+
<li><input type="radio" name="sort-by" value="alpha-desc" aria-label="Board Name (Z to A)"> Board Name (Z to A)</li>
45+
</ul>
46+
</fieldset>
4047
</div>
4148
</div>
4249
</div>
@@ -50,7 +57,7 @@ <h2>Sort By</h2>
5057
<a href="{{ board.url | relative_url }}">
5158
<div>
5259
<div class="img-responsive-4by3">
53-
<img src="{{ board.board_image | relative_url }}">
60+
<img src="{{ board.board_image | relative_url }}" alt="Image of Board">
5461
</div>
5562
<div class="details">
5663
<h3>{{ board.name }}</h3>

‎downloads.html

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,31 +13,37 @@ <h1>Downloads</h1>
1313
</label>
1414
</div>
1515
<div class="downloads-filter">
16-
<button class="filter"><i class="fas fa-sliders-h"></i></button>
16+
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h" aria-hidden="true"></i></button>
1717
</div>
1818
<div class="downloads-filter-tags">
1919
</div>
2020
</div>
2121
<div class="downloads-filter-content">
2222
<div class="filter-buttons">
23-
<button class="save-changes"><i class="fas fa-times"></i></button>
23+
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times" aria-hidden="true"></i></button>
2424
</div>
2525
<div>
2626
<div class="manufacturers">
27-
<h2>Manufacturers</h2>
28-
<ul class="content"></ul>
27+
<fieldset>
28+
<legend>Manufacturers</legend>
29+
<ul class="content"></ul>
30+
</fieldset>
2931
</div>
3032
<div class="features">
31-
<h2>Features</h2>
32-
<ul class="content"></ul>
33+
<fieldset>
34+
<legend>Features</legend>
35+
<ul class="content"></ul>
36+
</fieldset>
3337
</div>
3438
<div class="sort-by">
35-
<h2>Sort By</h2>
36-
<ul class="content">
37-
<li><input type="radio" name="sort-by" value="downloads" checked> Downloads</li>
38-
<li><input type="radio" name="sort-by" value="alpha-asc"> Board Name (A to Z)</li>
39-
<li><input type="radio" name="sort-by" value="alpha-desc"> Board Name (Z to A)</li>
40-
</ul>
39+
<fieldset>
40+
<legend>Sort By</legend>
41+
<ul class="content">
42+
<li><input type="radio" name="sort-by" value="downloads" aria-label="Downloads" checked> Downloads</li>
43+
<li><input type="radio" name="sort-by" value="alpha-asc" aria-label="Board Name (A to Z)"> Board Name (A to Z)</li>
44+
<li><input type="radio" name="sort-by" value="alpha-desc" aria-label="Board Name (Z to A)"> Board Name (Z to A)</li>
45+
</ul>
46+
</fieldset>
4147
</div>
4248
</div>
4349
</div>
@@ -57,7 +63,7 @@ <h2>Sort By</h2>
5763
{% if info.downloads_display == false %}
5864
{% continue %}
5965
{% endif %}
60-
66+
6167
<div class="download" data-id="{{ board.id }}"
6268
data-name="{{ info.name | default: board.id }}"
6369
data-downloads="{{ board.downloads }}"
@@ -66,7 +72,7 @@ <h2>Sort By</h2>
6672
<a href="{{ info.url | relative_url }}">
6773
<div>
6874
<div class="img-responsive-4by3">
69-
<img src="{{ info.board_image | relative_url }}">
75+
<img src="{{ info.board_image | relative_url }}" alt="Image of Board">
7076
</div>
7177
<div class="details">
7278
<h3>{{ info.name | default: board.id }}</h3>
@@ -92,7 +98,7 @@ <h3>{{ info.name | default: board.id }}</h3>
9298
<a href="{{ board.url | relative_url }}">
9399
<div>
94100
<div class="img-responsive-4by3">
95-
<img src="{{ board.board_image | relative_url }}">
101+
<img src="{{ board.board_image | relative_url }}" alt="Image of Board">
96102
</div>
97103
<div class="details">
98104
<h3>{{ board.name }}</h3>

‎feed.xml

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)