Skip to content

Update missing boards Batch 2 #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

makermelissa
Copy link
Collaborator

Here are the rest of the Blinka boards. This is part 2. Part 1 was in #1194. This brings the count up to 120.

@makermelissa makermelissa requested a review from a team May 8, 2023 23:09
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get these images? What license are they under?

Want to include distro info on the pages?

@makermelissa
Copy link
Collaborator Author

makermelissa commented May 9, 2023

Where did you get these images?

Various places. Let's See:
I got the LubanCat ones from Taobao
I got the ROC-RK3328-CC from Libre Computer's product page (which I linked to for purchase)
I got the Jetson Images from the Purchase Pages I linked to.
I got the Radxa ones from the Purchase pages I linked to.

What license are they under?

I'm not sure. Finding images for these boards was difficult itself.

Want to include distro info on the pages?

I think we should add that in another PR. I'm still thinking about how I want to format the info. I'm thinking I may want to use a list, but I want to probably add it to the checker scripts so we don't end up with 20 different spellings of Debian or maybe I'll just make it part of the description.

@tannewt
Copy link
Member

tannewt commented May 10, 2023

I'm not sure. Finding images for these boards was difficult itself.

I'm wary about using pictures we don't necessarily have the rights to use. I realize that other images may be in the same bucket though.

@makermelissa
Copy link
Collaborator Author

I'm not sure. Finding images for these boards was difficult itself.

I'm wary about using pictures we don't necessarily have the rights to use. I realize that other images may be in the same bucket though.

Fair enough. How would you like to proceed?

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during our meeting and decided product photos are ok as long as we link to the shop where it came. (And we don't hear otherwise.)

@makermelissa makermelissa merged commit 5f00708 into adafruit:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants