Skip to content

Accessibility Changes #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 22, 2019
Merged

Accessibility Changes #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19cdc03
add lang to root html element
jwcooper May 22, 2019
7259dd9
add section elements to home page
jwcooper May 22, 2019
58fa79f
remove unused feed and post files
jwcooper May 22, 2019
874c9ba
add missing alt tags on images
jwcooper May 22, 2019
9921a0d
add title to buttons
jwcooper May 22, 2019
c4e0fc7
add sections for libraries page
jwcooper May 22, 2019
19d3f33
use h2 for landing page header sections
jwcooper May 22, 2019
d9e42fd
better forms for screen readers
jwcooper May 22, 2019
21097ea
clean up font awesome icons with aria-hidden and titles as necessary
jwcooper May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ gem "jekyll", "~> 3.8.4"
# If you have any plugins, put them here!
group :jekyll_plugins do
gem 'jekyll-sitemap'
gem 'jekyll-feed'
gem 'jekyll-seo-tag'
gem 'jekyll-paginate'
end
3 changes: 0 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ GEM
pathutil (~> 0.9)
rouge (>= 1.7, < 4)
safe_yaml (~> 1.0)
jekyll-feed (0.11.0)
jekyll (~> 3.3)
jekyll-paginate (1.1.0)
jekyll-sass-converter (1.5.2)
sass (~> 3.4)
Expand Down Expand Up @@ -65,7 +63,6 @@ PLATFORMS

DEPENDENCIES
jekyll (~> 3.8.4)
jekyll-feed
jekyll-paginate
jekyll-seo-tag
jekyll-sitemap
Expand Down
2 changes: 1 addition & 1 deletion _includes/download/blinka.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h3>Adafruit Blinka Installation</h3>
so much because they all happen underneath the adafruit_blinka layer.
</p>
<div>
<a class="download-button" href="{{ page.download_instructions }}">INSTALLATION INSTRUCTIONS<i class="fas fa-arrow-circle-right"></i></a>
<a class="download-button" href="{{ page.download_instructions }}">INSTALLATION INSTRUCTIONS<i class="fas fa-arrow-circle-right" aria-hidden="true"></i></a>
<div class="clear"></div>
</div>
</div>
6 changes: 3 additions & 3 deletions _includes/download/board.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ <h3>CircuitPython {{ version.version }}</h3>
</label>
<div class="download-buttons">
{% for file in version.files['en_US'] %}
<a class="download-button {% if version.stable %}stable{% else %}unstable{% endif %} {{ file | slice: -3, 3 }}" href="{{ file }}">DOWNLOAD {{ file | slice: -4, 4 | upcase }} NOW <i class="fas fa-download"></i></a>
<a class="download-button {% if version.stable %}stable{% else %}unstable{% endif %} {{ file | slice: -3, 3 }}" href="{{ file }}">DOWNLOAD {{ file | slice: -4, 4 | upcase }} NOW <i class="fas fa-download" aria-hidden="true"></i></a>
{% endfor %}
</div>
</div>
Expand All @@ -70,7 +70,7 @@ <h3>Absolute Newest</h3>
the absolute latest and are feeling risky.
</p>
<div>
<a class="download-button-unrecommended" href="https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/{{ page.board_id }}/">BROWSE S3<i class="fas fa-arrow-circle-right"></i></a>
<a class="download-button-unrecommended" href="https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/{{ page.board_id }}/">BROWSE S3<i class="fas fa-arrow-circle-right" aria-hidden="true"></i></a>
<div class="clear"></div>
</div>
</div>
Expand All @@ -81,7 +81,7 @@ <h3>Past Releases</h3>
the latest stable otherwise.
</p>
<div>
<a class="download-button-unrecommended" href="https://github.com/adafruit/circuitpython/releases">BROWSE GITHUB<i class="fab fa-github"></i></a>
<a class="download-button-unrecommended" href="https://github.com/adafruit/circuitpython/releases">BROWSE GITHUB<i class="fab fa-github" aria-hidden="true"></i></a>
<div class="clear"></div>
</div>
</div>
2 changes: 1 addition & 1 deletion _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html>
<html lang="en">

{% include head.html %}

Expand Down
31 changes: 0 additions & 31 deletions _layouts/post.html
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion assets/javascript/downloads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ function shouldDisplayDownload(download, displayedManufacturers, displayedFeatur
}

function appendFilterTag(type, name) {
var tagHtml = "<span class='tag'><i class='fas fa-times tag-remove' ";
var tagHtml = "<span class='tag'><i class='fas fa-times tag-remove' title='Remove Filtered Option'";
tagHtml += "data-type='" + type + "' ";
tagHtml += "data-name='" + name + "'></i>";
tagHtml += name + "</span>";
Expand Down
9 changes: 9 additions & 0 deletions assets/sass/base/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,12 @@ a.purple-button-link {
padding-left: 10px;
}
}

fieldset {
border: 0;

legend {
font-size: 1.5em;
font-weight: 500;
}
}
3 changes: 2 additions & 1 deletion assets/sass/pages/_home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@
}

.content {
h1 {
h2 {
width: 75%;
margin: 20px auto;
font-size: 2em;
}

p {
Expand Down
33 changes: 20 additions & 13 deletions blinka.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,41 @@ <h1>Blinka</h1>
<div class="downloads-inputs">
<div class="downloads-search">
<label class="search-wrapper">
<input type="text" id="search" placeholder="Search for CircuitPython boards" />
<input aria-label="Search for Blinka boards" type="text" id="search" placeholder="Search for Blinka boards" />
</label>
</div>
<div class="downloads-filter">
<button class="filter"><i class="fas fa-sliders-h"></i></button>
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h" aria-hidden="true"></i></button>
</div>
<div class="downloads-filter-tags">
</div>
</div>
<div class="downloads-filter-content">
<div class="filter-buttons">
<button class="save-changes"><i class="fas fa-times"></i></button>
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times" aria-hidden="true"></i></button>
</div>
<div>
<div class="manufacturers">
<h2>Manufacturers</h2>
<ul class="content"></ul>
<fieldset>
<legend>Manufacturers</legend>
<ul class="content"></ul>
</fieldset>
</div>
<div class="features">
<h2>Features</h2>
<ul class="content"></ul>
<fieldset>
<legend>Features</legend>
<ul class="content"></ul>
</fieldset>
</div>
<div class="sort-by">
<h2>Sort By</h2>
<ul class="content">
<li><input type="radio" name="sort-by" value="alpha-asc" checked> Board Name (A to Z)</li>
<li><input type="radio" name="sort-by" value="alpha-desc"> Board Name (Z to A)</li>
</ul>
<fieldset>
<legend>Sort By</legend>
<ul class="content">
<li><input type="radio" name="sort-by" value="downloads" aria-label="Downloads" checked> Downloads</li>
<li><input type="radio" name="sort-by" value="alpha-asc" aria-label="Board Name (A to Z)"> Board Name (A to Z)</li>
<li><input type="radio" name="sort-by" value="alpha-desc" aria-label="Board Name (Z to A)"> Board Name (Z to A)</li>
</ul>
</fieldset>
</div>
</div>
</div>
Expand All @@ -50,7 +57,7 @@ <h2>Sort By</h2>
<a href="{{ board.url | relative_url }}">
<div>
<div class="img-responsive-4by3">
<img src="{{ board.board_image | relative_url }}">
<img src="{{ board.board_image | relative_url }}" alt="Image of Board">
</div>
<div class="details">
<h3>{{ board.name }}</h3>
Expand Down
36 changes: 21 additions & 15 deletions downloads.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,37 @@ <h1>Downloads</h1>
</label>
</div>
<div class="downloads-filter">
<button class="filter"><i class="fas fa-sliders-h"></i></button>
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h" aria-hidden="true"></i></button>
</div>
<div class="downloads-filter-tags">
</div>
</div>
<div class="downloads-filter-content">
<div class="filter-buttons">
<button class="save-changes"><i class="fas fa-times"></i></button>
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times" aria-hidden="true"></i></button>
</div>
<div>
<div class="manufacturers">
<h2>Manufacturers</h2>
<ul class="content"></ul>
<fieldset>
<legend>Manufacturers</legend>
<ul class="content"></ul>
</fieldset>
</div>
<div class="features">
<h2>Features</h2>
<ul class="content"></ul>
<fieldset>
<legend>Features</legend>
<ul class="content"></ul>
</fieldset>
</div>
<div class="sort-by">
<h2>Sort By</h2>
<ul class="content">
<li><input type="radio" name="sort-by" value="downloads" checked> Downloads</li>
<li><input type="radio" name="sort-by" value="alpha-asc"> Board Name (A to Z)</li>
<li><input type="radio" name="sort-by" value="alpha-desc"> Board Name (Z to A)</li>
</ul>
<fieldset>
<legend>Sort By</legend>
<ul class="content">
<li><input type="radio" name="sort-by" value="downloads" aria-label="Downloads" checked> Downloads</li>
<li><input type="radio" name="sort-by" value="alpha-asc" aria-label="Board Name (A to Z)"> Board Name (A to Z)</li>
<li><input type="radio" name="sort-by" value="alpha-desc" aria-label="Board Name (Z to A)"> Board Name (Z to A)</li>
</ul>
</fieldset>
</div>
</div>
</div>
Expand All @@ -57,7 +63,7 @@ <h2>Sort By</h2>
{% if info.downloads_display == false %}
{% continue %}
{% endif %}

<div class="download" data-id="{{ board.id }}"
data-name="{{ info.name | default: board.id }}"
data-downloads="{{ board.downloads }}"
Expand All @@ -66,7 +72,7 @@ <h2>Sort By</h2>
<a href="{{ info.url | relative_url }}">
<div>
<div class="img-responsive-4by3">
<img src="{{ info.board_image | relative_url }}">
<img src="{{ info.board_image | relative_url }}" alt="Image of Board">
</div>
<div class="details">
<h3>{{ info.name | default: board.id }}</h3>
Expand All @@ -92,7 +98,7 @@ <h3>{{ info.name | default: board.id }}</h3>
<a href="{{ board.url | relative_url }}">
<div>
<div class="img-responsive-4by3">
<img src="{{ board.board_image | relative_url }}">
<img src="{{ board.board_image | relative_url }}" alt="Image of Board">
</div>
<div class="details">
<h3>{{ board.name }}</h3>
Expand Down
30 changes: 0 additions & 30 deletions feed.xml
View file
Open in desktop

This file was deleted.

Loading