Resize and optimize image sizes #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to fall back to the scaled original if it is only available? |
|
We can do it with javascript, but I haven't found a way with only html/css that works reliably. I'll add the javascript fallback before we're ready to review. |
|
Could we use Jekyll to do it? |
|
Great idea, will try that quick. Looks like you can test if a file exists with jekyll and liquid. |
|
We'll now fallback to the original image if the large or small sizes do not exist (using jekyll). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Yet...
Script to resize originally uploaded files to two different sizes, optimize sizes and load them properly for viewport size.
Current /downloads size: 29.23MB
New /downloads size: 1.47MB
To start, we'll either need people to upload 3 images for new boards (original, 300 px width, 700 px width), or run the script after adding a new board. Updated readme for the instructions on adding 3 images.