Skip to content

bootloaders.json - remove trailing commas & add 82 boards #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2021

Conversation

durapensa
Copy link
Contributor

@durapensa durapensa commented Sep 18, 2021

Tested locally, makes mcufamily search/filter inclusive all 234 boards displayed.

Note, removing trailing commas was required for Python's JSON module to not barf on loading the file (the revised bootloaders.json was generated from a python script, so there are a few alphabetical reorders & other json cleanups too). Jekyll seems happy either way.

FoamyGuy
FoamyGuy previously approved these changes Sep 19, 2021
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I tested the changes locally and verified a handful full of devices still show proper bootloader information on their downloads page.

Thanks for this cleanup and the additions @durapensa

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I pushed another commit which cleaned up the bootloader doc a bit. There was some redundant text and I also normalized the formatting.

I re-tested with local builds and also verified the HTML to make sure the tags matched up.

@dhalbert dhalbert merged commit 0b3b0b6 into adafruit:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants