-
Notifications
You must be signed in to change notification settings - Fork 653
migrate family & bootloader_id to board.md files, add mcu family search" #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate family & bootloader_id to board.md files, add mcu family search" #766
Conversation
At a glance this looks good, but I want to test this locally before approving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to track that down, and it should be resolved now (fix in commit above). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the undefined
option is gone for me now. However, it looks like the filters on the Blinka page have stopped functioning.
More specifically, the clicking the Filters button doesn't bring up any filters. |
I didn't test that! ;-) Nice catch. Fix was: rather than add conditionals to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response. It appears to be working great!
A cleaned-up version of #756 (supersedes that PR), including discussed migration of
family
&bootloader_id
toboard.md
files per @makermelissa's suggestion.bootloaders.json
now contains only bootloader port (family) & version information, and no longer contains board information.Tested locally such that
_includes/download/board.html
points to the correct downloads for CircuitPython & UF2 bootloader, and search/filter works as in #756.