Skip to content

migrate family & bootloader_id to board.md files, add mcu family search" #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

durapensa
Copy link
Contributor

A cleaned-up version of #756 (supersedes that PR), including discussed migration of family & bootloader_id to board.md files per @makermelissa's suggestion.

bootloaders.json now contains only bootloader port (family) & version information, and no longer contains board information.

Tested locally such that _includes/download/board.html points to the correct downloads for CircuitPython & UF2 bootloader, and search/filter works as in #756.

@makermelissa
Copy link
Collaborator

At a glance this looks good, but I want to test this locally before approving.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MCU family is showing undefined. I think the fix may be to add an if statement to the code logic, but I'm not entirely sure.
Screen Shot 2021-09-21 at 11 26 04 AM

@durapensa
Copy link
Contributor Author

durapensa commented Sep 21, 2021

I've been trying to track that down, and it should be resolved now (fix in commit above).

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the undefined option is gone for me now. However, it looks like the filters on the Blinka page have stopped functioning.

@makermelissa
Copy link
Collaborator

More specifically, the clicking the Filters button doesn't bring up any filters.

@durapensa
Copy link
Contributor Author

I didn't test that! ;-) Nice catch.

Fix was: rather than add conditionals to assets/javascript/downloads.js, just make it happy by supplying it with empty mcufamily data from blinka.html.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. It appears to be working great!

@makermelissa makermelissa merged commit ea1eba3 into adafruit:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants