Skip to content

Add Seeed_XIAO_nRF52840_Sense board info #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2022
Merged

Add Seeed_XIAO_nRF52840_Sense board info #827

merged 3 commits into from
Jan 4, 2022

Conversation

0hotpotman0
Copy link
Contributor

No description provided.

@tannewt tannewt requested a review from makermelissa December 29, 2021 17:37
makermelissa
makermelissa requested changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for submitting. Please keep the features limited to the list on this page: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads. You can move the text for the feature list you do have down into the description.

The reason for that is the features filter options are automatically generated based on the items and even slight spelling differences will generate duplicate options. Thanks.

@0hotpotman0
Copy link
Contributor Author

Hi, thanks for submitting. Please keep the features limited to the list on this page: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads. You can move the text for the feature list you do have down into the description.

The reason for that is the features filter options are automatically generated based on the items and even slight spelling differences will generate duplicate options. Thanks.

Make sense

makermelissa
makermelissa requested changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like there's still some default text.

_board/Seeed_XIAO_nRF52840_Sense.md Outdated
Comment on lines 25 to 27
This board hasn't been fully documented yet. Please make a pull request adding more info to this file.

The description should be written to inform a CircuitPython user what makes the board unique and link to relevant info about it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you didn't mean to leave these lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... I didn't realize it...

makermelissa
makermelissa approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@makermelissa makermelissa merged commit 52f2598 into adafruit:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0hotpotman0 @makermelissa