Skip to content

Add TTGO T8 ESP32-S2 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

fabaff
Copy link
Contributor

@fabaff fabaff commented Mar 8, 2022

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a bit of whitespace around the board images. Here's a guide with some information about the image sizes we're looking for:
https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images

@fabaff fabaff force-pushed the lilygo-ttgo-esp32-s2-nodisplay branch from ca07eed to 1ce6a8d Compare March 9, 2022 12:43
@fabaff
Copy link
Contributor Author

fabaff commented Mar 9, 2022

Could you add a bit of whitespace around the board images.

Images are now replaced by "actual" images.

@fabaff fabaff requested a review from makermelissa March 9, 2022 15:29
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you.

@makermelissa makermelissa merged commit 25d5c9c into adafruit:main Mar 9, 2022
@fabaff fabaff deleted the lilygo-ttgo-esp32-s2-nodisplay branch March 9, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants