Skip to content

Add mixgo CE board information #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022
Merged

Conversation

dahanzimin
Copy link
Contributor

Thank circuitpython for adding a new board to circuitpython org. I hope it can pass

Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the features: portion of the board information, please only use the values listed in the template:

# Features are tags; they should be limited to the items in this list and spelled exactly the same.
# Include only the features your board supports, and remove these comment lines before committing.
# Breadboard-Friendly is a parallel pin layout with minimal non-critical perpendicular pins
features:
  - Speaker
  - Solder-Free Alligator Clip
  - Feather-Compatible
  - Battery Charging
  - Display
  - Wi-Fi
  - Bluetooth/BTLE
  - Robotics
  - LoRa/Radio
  - GPS
  - STEMMA QT/QWIIC
  - USB-C
  - Breadboard-Friendly
  - Arduino Shield Compatible

Modify features
Copy link
Contributor Author

@dahanzimin dahanzimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify features

@jepler
Copy link
Contributor

jepler commented May 11, 2022

Has this board been added to circuitpython? A board definition needs to be added to circuitpython first, then the board can be listed on circuitpython.org

@dahanzimin
Copy link
Contributor Author

Thank you. I've submitted the application board at circuit python. Let's pass it later

@makermelissa
Copy link
Collaborator

Note: This is waiting on adafruit/circuitpython#6383 to be merged first.

@dahanzimin
Copy link
Contributor Author

@makermelissa Thanks for your help and support. adafruit/circuitpython#6383has been merged. The same board corresponds to different modes (circuit Python combines two boards). Here are also two pages to correspond. Thank you

@makermelissa
Copy link
Collaborator

makermelissa commented May 23, 2022

Ok cool. One more request. I just noticed as I was giving this a final look over, your images are square. Could you adjust them so they are rectangular as described here: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images. Just cropping the top and bottom of the images a bit should do it.

Otherwise this looks good. Thanks.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you.

@makermelissa makermelissa merged commit 942dfde into adafruit:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants