Merge pull request #1850 from katlings/filter-underscores

Filter private methods from tab completion

Author: tannewt

py/repl.c

@@ -187,6 +187,11 @@ size_t mp_repl_autocomplete(const char *str, size_t len, const mp_print_t *print
                 if (s_len <= d_len && strncmp(s_start, d_str, s_len) == 0) {
                     mp_load_method_protected(obj, q, dest, true);
                     if (dest[0] != MP_OBJ_NULL) {
+                        // special case; filter out words that begin with underscore
+                        // unless there's already a partial match
+                        if (s_len == 0 && d_str[0] == '_') {
+                            continue;
+                        }
                         if (match_str == NULL) {
                             match_str = d_str;
                             match_len = d_len;

tests/cmdline/repl_autocomplete.py

@@ -6,4 +6,7 @@
 1, x.isdi	()
 i = str
 i.lowe	('ABC')
+x = 5
+x.	
+x._	
 None.	

tests/cmdline/repl_autocomplete.py.exp

@@ -10,5 +10,11 @@ Use \.\+
 >>> i = str
 >>> i.lower('ABC')
 'abc'
+>>> x = 5
+>>> x.
+from_bytes      to_bytes
+>>> x.
+>>> x.__class__
+<class 'int'>
 >>> None.
 >>> 

tests/unix/extra_coverage.py.exp

@@ -27,11 +27,11 @@ RuntimeError:
 # repl
 ame__
 
-__class__       __name__        argv            byteorder
-exc_info        exit            getsizeof       implementation
-maxsize         modules         path            platform
-print_exception                 stderr          stdin
-stdout          version         version_info
+argv            byteorder       exc_info        exit
+getsizeof       implementation  maxsize         modules
+path            platform        print_exception
+stderr          stdin           stdout          version
+version_info
 ementation
 # attrtuple
 (start=1, stop=2, step=3)