Skip to content

Fix nrf internal flash #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Nov 15, 2018

nRF internal flash didn't fake out the partition table like atmel does. Now its factored out.

@tannewt tannewt added this to the 4.0 Alpha milestone Nov 15, 2018
Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built and tested on pca10059 (nrf52840 dongle) and on feather_nrf52832
Both appear to work normally.
It takes about 10 seconds or so for REPL to appear on pca10059 -- got nervous ;-)
On feather_nrf52832 if SPI is used then a soft RESET (control-D) is issued another attempt to use SPI results inc"SCK in use" error. A Hard RESET clears the condition and it works as expected.
Tested ampy access to feather_nrf52832 -- tried ls,get,put -- all ok

also tested on pca10056 (nrf52840 DK) looks good.

@dhalbert
Copy link
Collaborator

If the delayed REPL is consistent, then an issue should be opened. It might have been a long write to BOOT_OUT.TXT (because the version changed).

@dhalbert dhalbert merged commit 7e2a3bf into adafruit:master Nov 15, 2018
@dhalbert
Copy link
Collaborator

I see the slow REPL response as well. CIRCUITPY is almost immediate. I can connect to the serial port immediately, but it takes about 7 seconds for the REPL prompt to show up. This is true after multiple resets (it's not just the first one, which might write BOOT_OUT.txt). I'l make an issue with some more data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants