Use critical section, not lock, in CharacteristicBuffer; use a root pointer for ble_drv list #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointer for ble_drv list
|
@kattni you can test this in combination with adafruit/Adafruit_CircuitPython_BluefruitConnect#10. |
kattni
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Tested successfully with update found here: adafruit/Adafruit_CircuitPython_BluefruitConnect#10
Works great! Thank you for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems with BLE:
ble_drvlinked list start with a root pointer. Its allocated storage was getting gc'd and reused.I reordered some
#include's for clarity, but the order doesn't matter (I thought it did).Partly fixes #1568. The other part is adafruit/Adafruit_CircuitPython_BluefruitConnect#10.