Skip to content

Final displayio changes before 4.0.0 #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2019
Merged

Final displayio changes before 4.0.0 #1640

merged 6 commits into from
Mar 13, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 12, 2019

This should be the last API changes before 4.0.0.

  • I removed networking from M0 builds in order to fit it.
  • Changed TileGrid to use x and y instead of position and also adds subscript support for changing tiles.
  • Group can now take x and y in it's constructor too.
  • TileGrid and Group were updated to always use native_foo helpers to ensure we pass the native object to shared-module.
  • I updated the docs for displayio, FourWire and ParallelBus.

@tannewt tannewt added this to the 4.0.0 - Bluetooth milestone Mar 12, 2019
tannewt added 5 commits March 12, 2019 17:17
@tannewt
Accept x and y kwargs into Group for initial position.
ea45877
@tannewt
Turn off networking on M0s.
96a924f 
It takes 10k of code space and isn't very useful because of the
M0's limited RAM. Disabling it allows us to add other things.
@tannewt
Standardize TileGrid to x and y properties over position
224e9b1 
This brings it inline with Group. Also fixes micropython#1613

This also includes a number of fixes for where a method is called
through a subclass. We now correctly get the native object.
Fixes micropython#1567

Lastly, this adds subscript support to TileGrid for changing tile
indices. Similar to Bitmap, it accepts ints or 2-tuples.
@tannewt
Update displayio docs to add detail to display bus comments
afbf590 
Fixes micropython#1599
@tannewt
Add better PewPew error messages and update translations
946790b
@tannewt tannewt force-pushed the final_displayio_changes branch from f10b87f to 946790b Compare March 13, 2019 00:21
dhalbert
dhalbert reviewed Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question re whether pewpew is still buildable. If it's fine, then I'll approve as soon as Travis is happy.

dhalbert
dhalbert approved these changes Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine on the pewpew build: it's a good vetting that the underlying code still compiles.

@dhalbert dhalbert merged commit 494a9d3 into adafruit:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshipu deshipu deshipu left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
bug displayio enhancement
Projects
None yet
Milestone
4.0.0 - Bluetooth
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @deshipu @dhalbert