WIP: Circuitpython nickzoic 1800 wiznet socket

[nickzoic]

• Fixes problems experienced in Ethernet FeatherWing Library #703 W5500 problem #1500 and no socket communication with W5500 ethernet wing and feather m4 express #1800 with DHCP interfering with open sockets.

• Adds "dhcp" as a boolean argument to wiznet constructor (keyword only, default True)
  Setting "dhcp=False" will prevent DHCP from starting. It can still be started by setting the .dhcp
  property.

[nickzoic]

OK I've made some builds for revision d97c81b and temporarily made them available at:

[temporary location removed now that this is merged back]

If all goes well, I expect this PR will get merged back into CircuitPython proper shortly after PyCon, but these should at least let you all test the new code now and see if it solves your problem!

[tannewt]

Has anyone tested this for you?

[tannewt]

What are the XXX comments for? Can you either remove them or rephrase them as TODO: <explanation of what to do?? Thanks!

[nickzoic]

Has anyone tested this for you?

@gvcp has been doing some testing down the bottom of #1800 ... still got a couple of little issues which I'll look at tomorrow.

What are the XXX comments for?

That one's there to remind me to ask you whether you think dhcp should be automatically set to False when someone manually configures an address :-)

UPDATE: Argh, clicked wrong button! Need more coffee, or maybe less coffee.

[ladyada]

yah if they set an address, dont use dhcp by default

[gvcp]

Is the uf2 image for the feather M4 express with the changes blow available anywhere for further testing ?

@nickzoic pushed 3 commits.

e00a702 Stop DHCP when configuring IP address adafruit/circuitpython#1800
af0bba0 reset wiznet at network deinitialize adafruit/circuitpython#1800
0d08dde randomize tcp source port for adafruit/circuitpython#1800

[tannewt]

Merging these so they get in the RC. Any bugs we can fix with later versions. I won't block the stable release on networking issues though. Thanks @nickzoic and @gvcp

[ladyada]

agree on not blocking on ethernet, its something i'd like to have working for those who dont/cant use wifi but most use wifi ;)

[nickzoic]

On Sat, 11 May 2019, at 03:16, gvcp wrote: Is the uf2 image for the feather M4 express with the changes blow available anywhere for further testing ?

It's in the latest Release Candidate: https://github.com/adafruit/circuitpython/releases/tag/4.0.0-rc.2 (click on "Assets" down the very bottom of that page) Doesn't mean we won't keep fixing stuff ... thanks for your help with testing and keep reporting issues if you find them! For starters, I'll raise a separate issue for fixing up the exceptions, eg: something better than numbers `OSError`s.

…

-----N