Add overflow checks for int to bytes conversions #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
int_to_bytes_overflow_checks
branch
from
a67c61b to
f9ca13a
Compare
|
Thanks! Please ping me when you are ready for a review. |
|
One of the Travis failures is for a board running out of space... I'll try implementing this without the intermediate |
godlygeek
force-pushed
the
int_to_bytes_overflow_checks
branch
3 times, most recently
from
f3b4d37 to
4c253af
Compare
added 4 commits
May 9, 2019 03:22
For both small and long integers, raise an exception if calling struct.pack, adding an element to an array.array, or formatting an int with int.to_bytes would overflow the requested size.
Initially I used one of the existing exception raise functions, but it's more correct and not much more code to raise OverflowError instead.
godlygeek
force-pushed
the
int_to_bytes_overflow_checks
branch
from
4c253af to
fb7bb40
Compare
godlygeek
changed the title
|
@tannewt I think this is ready for a review. |
tannewt
requested changes
May 9, 2019
Rather than jumping to a label when an overflow is known to have occurred, return early when one is known not to have.
|
@tannewt - goto's removed, please take another look. |
This was referenced May 11, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both small and long integers, raise an exception if calling
struct.pack, adding an element to anarray.array, or formatting anintwithint.to_byteswould overflow the requested size.