Skip to content

Include sphinx and recommonmark in docs/requirements.txt #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2019

Conversation

amyreese
Copy link

@amyreese amyreese commented May 12, 2019

These packages seem necessary for building docs via make html.
This also pins the dependency versions to ensure a compatible version of sphinx is used.

@amyreese
Copy link
Author

Note: make html still fails for me on my machines (macOS 10.14, Python 3.5, 3.6, or 3.7). Failure logs: https://gist.github.com/jreese/a6adf9e5dca020dd77080a08448fe952

@sommersoft
Copy link

Note: make html still fails for me on my machines (macOS 10.14, Python 3.5, 3.6, or 3.7). Failure logs:

The only difference I see between your logs, and Travis/RTD, is that you're running in Sphinx 2.0.1 vice 1.8.5. I don't see any open issues on GitHub, but maybe try v1.8.5?

@amyreese
Copy link
Author

That fixed the build error, thank you. I've updated the PR to include pinned versions to make sure the appropriate version is used.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit d845ce9 into adafruit:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants