Skip to content

Removed warning box regarding SAMD21 builds #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jpecor
Copy link

@jpecor jpecor commented May 25, 2019

The support matrix shows that pulseio is supported for all SAMD21/SAMD51 variants. Removing warning to avoid confusion.

The support matrix shows that pulseio is supported for all SAMD21/SAMD51 variants.   Removing warning to avoid confusion.
@dhalbert
Copy link
Collaborator

Thank you! The ground truth for these kinds of settings is in py/circuitpy_mpconfig.*, ports/*/mpconfigport.* ports/*/boards/mpconfigboard.*.

Would you be willing to resubmit this PR against branch 4.0.x? That will get it into a release version sooner. Thanks.

@jpecor
Copy link
Author

jpecor commented May 26, 2019

Oops! Meant to do it for 4. Yes, will do.

@dhalbert
Copy link
Collaborator

Closed in favor of #1916, which was applied against branch 4.0.x.

@dhalbert dhalbert closed this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants